|
Re: Proposal: Supervisor Timer CSR and Virtual Supervisor Timer CSR
Siqi,
Thanks. That narrows down where we are differing.
If the hypervisor has set hideleg bit 6 (so that VS-level timer interrupts can be received by VS-mode while V=1), then any new pending
Siqi,
Thanks. That narrows down where we are differing.
If the hypervisor has set hideleg bit 6 (so that VS-level timer interrupts can be received by VS-mode while V=1), then any new pending
|
By
Greg Favor
·
#337
·
|
|
Re: Proposal: Supervisor Timer CSR and Virtual Supervisor Timer CSR
Hi Greg,
I understand your concern. In fact, the goal is not to provide more than one vstimecmp CSR.
You are right that when a VM is context switched out, it's vstimecmp CSR is also switched out.
Hi Greg,
I understand your concern. In fact, the goal is not to provide more than one vstimecmp CSR.
You are right that when a VM is context switched out, it's vstimecmp CSR is also switched out.
|
By
Siqi Zhao
·
#336
·
|
|
Re: Proposal: Supervisor Timer CSR and Virtual Supervisor Timer CSR
Siqi,
Thanks for your clarification. If I understand correctly, your goal (analogous to SGEI as you mention) is to enable a pending virtual timer interrupt, even for a VM not currently context
Siqi,
Thanks for your clarification. If I understand correctly, your goal (analogous to SGEI as you mention) is to enable a pending virtual timer interrupt, even for a VM not currently context
|
By
Greg Favor
·
#335
·
|
|
Re: Disabling and re-enabling extensions
OK - taking a step back, what about requiring: any extension spec that doesn't specifically discuss enabling and disabling should be prohibited from enabling or disabling..
I can't see any good use
OK - taking a step back, what about requiring: any extension spec that doesn't specifically discuss enabling and disabling should be prohibited from enabling or disabling..
I can't see any good use
|
By
Allen Baum
·
#334
·
|
|
Re: Disabling and re-enabling extensions
The hypervisor spec specifically says that implementations should have writable misa so this isn't theoretical:
"The hypervisor extension is enabled by setting bit 7 in the misa CSR, which corresponds
The hypervisor spec specifically says that implementations should have writable misa so this isn't theoretical:
"The hypervisor extension is enabled by setting bit 7 in the misa CSR, which corresponds
|
By
Paul Donahue
·
#333
·
|
|
Re: Disabling and re-enabling extensions
I thought there was already a speced requirement that, at reset, all extensions are enabled.:
"At reset, theExtensions field shall contain the maximal set of supported extensions, and I shall be
I thought there was already a speced requirement that, at reset, all extensions are enabled.:
"At reset, theExtensions field shall contain the maximal set of supported extensions, and I shall be
|
By
Allen Baum
·
#332
·
|
|
Re: Disabling and re-enabling extensions
I think that the general statement for misa should definitely be that it's UNSPECIFIED. For instance, implementations may want to power gate a vector unit when V is disabled and that becomes more
I think that the general statement for misa should definitely be that it's UNSPECIFIED. For instance, implementations may want to power gate a vector unit when V is disabled and that becomes more
|
By
Paul Donahue
·
#331
·
|
|
Re: Disabling and re-enabling extensions
A potential second general requirement for all Priv extensions:
- The hart reset state must be fully specified and should generally be UNSPECIFIED except for any key control/status bits that need to
A potential second general requirement for all Priv extensions:
- The hart reset state must be fully specified and should generally be UNSPECIFIED except for any key control/status bits that need to
|
By
Greg Favor
·
#330
·
|
|
Re: Disabling and re-enabling extensions
I'm not sure, off-hand, if there is a many item list to be created or not. (Andrew probably has better thoughts on this.) But on the particular topic of this email thread, my leaning would be to say
I'm not sure, off-hand, if there is a many item list to be created or not. (Andrew probably has better thoughts on this.) But on the particular topic of this email thread, my leaning would be to say
|
By
Greg Favor
·
#329
·
|
|
Re: Disabling and re-enabling extensions
Is there a checklist of requirements for priv specifications?
if not should there be?
If there is, would this be a requirement in that list to specify to some level of clarity (maybe indicating what
Is there a checklist of requirements for priv specifications?
if not should there be?
If there is, would this be a requirement in that list to specify to some level of clarity (maybe indicating what
|
By
mark
·
#328
·
|
|
Re: Proposal: Supervisor Timer CSR and Virtual Supervisor Timer CSR
Hi Greg,
Thanks for the comments.
It seems the proposal is not explicit enough about the type of interrupt. So to answer your question, with vstimecmp, there is in fact a new type of interrupt types.
Hi Greg,
Thanks for the comments.
It seems the proposal is not explicit enough about the type of interrupt. So to answer your question, with vstimecmp, there is in fact a new type of interrupt types.
|
By
Siqi Zhao
·
#327
·
|
|
Re: Disabling and re-enabling extensions
I don’t object, but I’m wondering: would different implementations actually be motivated to have different behavior w.r.t. hypervisor state when H is disabled then re-enabled? Put another way, do
I don’t object, but I’m wondering: would different implementations actually be motivated to have different behavior w.r.t. hypervisor state when H is disabled then re-enabled? Put another way, do
|
By
andrew@...
·
#326
·
|
|
Re: Disabling and re-enabling extensions
(Compliance hat on):
I'd like to dig into that a bit further. This has come up in the context of WARL registers, where changing the value of some CSR field1 causes some other CSR field2 value to
(Compliance hat on):
I'd like to dig into that a bit further. This has come up in the context of WARL registers, where changing the value of some CSR field1 causes some other CSR field2 value to
|
By
Allen Baum
·
#325
·
|
|
Disabling and re-enabling extensions
In a belated followup to https://github.com/riscv/riscv-isa-manual/issues/332#issuecomment-466581845, I have the same question as John Hauser. One thing that has changed is that now the architecture
In a belated followup to https://github.com/riscv/riscv-isa-manual/issues/332#issuecomment-466581845, I have the same question as John Hauser. One thing that has changed is that now the architecture
|
By
Paul Donahue
·
#324
·
|
|
Re: Proposal: Supervisor Timer CSR and Virtual Supervisor Timer CSR
Fair enough. I was thinking of a system where the DVFS would be under the control of M-mode software, but in some chips it could be done by a more autonomous DVFS controller of some sort.
Sounds like
Fair enough. I was thinking of a system where the DVFS would be under the control of M-mode software, but in some chips it could be done by a more autonomous DVFS controller of some sort.
Sounds like
|
By
Phil McCoy
·
#323
·
|
|
Re: Proposal: Supervisor Timer CSR and Virtual Supervisor Timer CSR
Scale factors don't work if the clock is constantly changing e.g. DVFS
Scale factors don't work if the clock is constantly changing e.g. DVFS
|
By
Allen Baum
·
#322
·
|
|
Re: Proposal: Supervisor Timer CSR and Virtual Supervisor Timer CSR
Another option is to create memory-mapped registers for stimecmp/vstimecmp at addresses that are accessible to S-mode/VS-mode software.
Another option is to create memory-mapped registers for stimecmp/vstimecmp at addresses that are accessible to S-mode/VS-mode software.
|
By
Phil McCoy
·
#321
·
|
|
Re: Proposal: Supervisor Timer CSR and Virtual Supervisor Timer CSR
One of the main reasons for making mtime/mtimecmp memory-mapped rather than CSRs is to support systems where the CPU(s) do not run at a constant clock frequency. In such systems, the mtime counter
One of the main reasons for making mtime/mtimecmp memory-mapped rather than CSRs is to support systems where the CPU(s) do not run at a constant clock frequency. In such systems, the mtime counter
|
By
Phil McCoy
·
#320
·
|
|
Re: Proposal: Supervisor Timer CSR and Virtual Supervisor Timer CSR
zhaosiqi (Siqi) wrote:
There is an informal group that is working on a proposal for a RISC-V
"Advanced Interrupt Architecture", which includes replacements for
the current PLIC. No document is
zhaosiqi (Siqi) wrote:
There is an informal group that is working on a proposal for a RISC-V
"Advanced Interrupt Architecture", which includes replacements for
the current PLIC. No document is
|
By
John Hauser
·
#319
·
|
|
Re: Proposal: Supervisor Timer CSR and Virtual Supervisor Timer CSR
A few other small nits:
- Besides by S-mode and M-mode, the stimecmp CSR is accessible by HS-mode; and is accessible by VS-mode as well (during which the vstimecmp CSR contents substitute for stimecmp
A few other small nits:
- Besides by S-mode and M-mode, the stimecmp CSR is accessible by HS-mode; and is accessible by VS-mode as well (during which the vstimecmp CSR contents substitute for stimecmp
|
By
Greg Favor
·
#318
·
|