Re: [RISC-V] [tech-aia] [RISC-V] [tech-unixplatformspec] Review request for ACPI ECRs


Aaron Durbin
 



On Wed, Aug 3, 2022 at 8:17 AM Sunil V L <sunilvl@...> wrote:
Hi All,

We plan to send below two ECRs to UEFI forum on 08/08/2022. These two
ECRs don't have any dependency on any unfrozen specs.
Getting these two ECRs accepted by UEFI forum would help us to enable big
chunk of ACPI infrastructure patches for RISC-V.

         a) RHCT
         https://docs.google.com/document/d/1LlCefO_0GQ_7Tf3lzfMPETEfMlGo2FfLRJ09IMqJKEk/edit?usp=sharing

I don't think we should submit this one until we settle on how we convey behaviors outside of an ISA string. I suspect that will change so we should anticipate that. Right now we have ISA string plus CMO parameters as specific RHCT Nodes. Are we concerned about timing on adoption to push this in its current form? I ask because I'd rather not have this set in stone only for us to quickly come back and say "stop using these fields. we have a new node/mechanism to convey this information".  What do you think?

I brought up this topic in the TSC meeting this week as I indicated I would. I need to work with some others to formalize the direction, but that's going to take a little more time.
 

         b)MADT RINTC
         https://docs.google.com/document/d/1waaAqDyTWvYcCSd1Df-vj0EKCA1nukKF_puclaVYkSo/edit?usp=sharing

Aside from maybe wordsmithing a little more for clarity purposes (based on commentary) I think this one seems fine from my standpoint. 



Please feel free to provide comments in the document before 08/08.
The documents and feedback will be archived in the same folder.

Thanks
Sunil

On Tue, Jul 05, 2022 at 10:46:18PM +0530, Sunil V L via lists.riscv.org wrote:
> Hi All,
>
> Thanks a lot for great feedback over last week on the ECRs. I have
> created version 2 of the ECRs addressing most of the comments. We will be
> discussing this version of the ECRs in this week's meeting. Please
> provide your comments in this version of the documents.
>
> 1) Non-AIA ECRs
>         a) RHCT - version 2:
>         https://docs.google.com/document/d/1LlCefO_0GQ_7Tf3lzfMPETEfMlGo2FfLRJ09IMqJKEk/edit?usp=sharing
>         b)MADT RINTC - version 2:
>         https://docs.google.com/document/d/1waaAqDyTWvYcCSd1Df-vj0EKCA1nukKF_puclaVYkSo/edit?usp=sharing
> 2) AIA ECRs
>         a)  MADT - AIA RINTC (version 2) :
>         https://docs.google.com/document/d/1LBKD1gyi6kOfE3V2WiFOPz1h4MlmxHDj7vkjjfSygBo/edit?usp=sharing
>         b) MADT - AIA IMSIC/APLIC version 2:
>         https://docs.google.com/document/d/1zDainvcxD14eawsyc3y1s78zP7ruefyGzcsP1bBak3w/edit?usp=sharing

> PoC Code has been updated at same location as earlier.
>
> Thanks
> Sunil
>
> On Tue, Jun 21, 2022 at 11:18:02PM +0530, Sunil V L via lists.riscv.org wrote:
> > Hi All,
> >
> > Please review below Engineering Change Request (ECR) to update the ACPI
> > spec for enabling basic ACPI support for RISC-V.
> >
> > 1) Add INTC structure in MADT Table -                                                                                                                                                                     
> > https://docs.google.com/document/d/13YdZzUv0mRHBotdy4Qjqrzb-83mjM31AyEXXfgodcNw/edit?usp=sharing
> >
> > 2) Add new RISC-V Hart Capabilities Table (RHCT).
> > https://docs.google.com/document/d/1-hQMzSNTEfNqudIENhGxrrb0Yr5MEo4NcZwXZlvdx6k/edit?usp=sharing
> >
> > 3) Add AIA interrupt controllers in MADT table
> > https://docs.google.com/document/d/1rbdXsON4OMJ0QB3UvkfkIa8hdySbWArIKqPRUli7AU0/edit?usp=sharing
> >
> > First two ECRs do not have a dependency on any RVI specs which are not
> > frozen. But the third ECR  has a dependency on AIA spec to be frozen.
> > Hence this AIA ECR will NOT be sent to UEFI forum until AIA spec is frozen.
> >
> > The PoC for these ECRs is complete and ACPI enabled Linux boots on qemu
> > platform. Below are links to the source code for the PoC.
> > qemu - https://github.com/ventanamicro/qemu/tree/dev-upstream
> > edk2 - https://github.com/ventanamicro/edk2/tree/dev-upstream
> > edk2-platforms - https://github.com/ventanamicro/edk2-platforms/tree/dev-upstream
> > linux - https://github.com/ventanamicro/linux/tree/dev-upstream
> >
> > You can find how to build and test these changes in this link -
> > https://github.com/riscv-non-isa/riscv-acpi/wiki/PoC-:-How-to-build-and-test-ACPI-enabled-kernel
> >                                                                                                                                                                                                           
> > You can provide the feedback by commenting in the document itself. I am
> > hoping to send at least first two ECRs to UEFI forum by 8th August 2022.
> > So, appreciate your help to improve these ECRs before 4th August 2022
> > (45 days from today).
> >                                                                                                                                                                                                           
> > Feel free to reach out if you have any questions.
> >                                                                                                                                                                                                           
> > Thanks!
> > Sunil
> >
> >
> >
> >
> >
>
>
>
>
>





Join tech-unixplatformspec@lists.riscv.org to automatically receive all group messages.