Re: [PATCH v3] Add system reboot extension


Anup Patel
 

-----Original Message-----
From: Bin Meng <bmeng.cn@...>
Sent: 06 April 2020 17:26
To: Anup Patel <Anup.Patel@...>
Cc: tech-unixplatformspec@...; Atish Patra
<Atish.Patra@...>
Subject: Re: [RISC-V] [tech-unixplatformspec] [PATCH v3] Add system reboot
extension

On Mon, Apr 6, 2020 at 11:27 AM Anup Patel <anup.patel@...> wrote:

This patch adds SBI v0.2 compliant system reboot extension. It defines
the sbi_system_reboot function which does different things based on
reboot_type parameter:
1. shutdown - Power-off the entire system
2. cold reboot - Power-cycle the entire system 3. warm reboot -
Power-cycle only parts of system based on SOC vendor
design choices

The sbi_system_reboot function defined here is also a replacement of
SBI v0.1 shutdown function.

Signed-off-by: Atish Patra <atish.patra@...>
Signed-off-by: Anup Patel <anup.patel@...>
---
riscv-sbi.adoc | 47
+++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 47 insertions(+)
A general comment: it would be good to put the reason why a new
extension is introduced, to solve what issue.

Reviewed-by: Bin Meng <bmeng.cn@...>
As suggested on GitHub PR, I will rename SBI extension to "System reset
extension" where Shutdown and Reboot are types of system reset.

Regards,
Anup

Join {tech-unixplatformspec@lists.riscv.org to automatically receive all group messages.