Re: [PATCH V3 1/2] riscv-platform-spec: PLIC and CLINT for Linux-2022 platform

Greg Favor

On Mon, May 17, 2021 at 8:24 AM Abner Chang <renba.chang@...> wrote:
Hi Greg,
I am going to restructure the sections for PLIC/CLINT/MTIMER. I am not quite sure your preference of  "separate chapters that provide specs of the required PLIC and CLINT". The chapters in riscv-platform-spec are based on the platform definition, thus I think to have separate sections is good enough. The structure of sections would be looked as below,

What I was trying to separate out from the main part of the platform spec (which is about specifying requirements), is the detailed register-level definitions of certain hardware components (like the things you listed below).  The detailed low-level definitions of each of these components should be located either in separate appendix chapters or in separate sections of an appendix chapter like what SBSA does (either way is fine with me; and if you want to instead treat them as normal chapters/sections and not call them appendices, that is fine as well).  

The central point is that the main chapters/sections of the platform specs should call out the requirements for various components and then just reference the related "appendix" chapters/sections for the detailed register-level definition of the components.


1.1.3. Interrupt Controller  AIA  PLIC + CLINT [DEPRECATED] Interrupt Assignments

1.1.4. System Peripherals UART/Serial Console Clocks Timers ,Watchdog Timers Machine Mode Timer
With the above, we can remove section for Linux2024. Is this ok?


In the "M-mode timer" chapter, the offsets should be rebased to 0x0, i.e. the mtimecmp registers start at offset 0x0000, and mtime is at 0x7FF8.



Join { to automatically receive all group messages.