Hi Abner, Yes, your understanding is correct. The 0xA000000 + opensbi_imp_id is the SBI Firmware code base extension meant to be used by OpenSBI. Now EDK2 uses unmodified OpenSBI as

That is fine, just realize that if you are using OpenSBI's implementation ID then you need to get approval from them before defining the extension. Jonathan

Basically OpenSBI is a git submodule of edk2 and we don’t make any modification on it, we just build OpenSBI on edk2 build environment. Yes, edk2 will have its own control of extensions for those

Is the code for the extension you want to add going to live in the OpenSBI repository or in the EDK2 repository? If I understand correctly, it would live in the EDK2 repository, meaning that your

Hi Abner, We have two options here: EDK2 can use 0xA000000 + <opensbi_imp_id> as SBI Extension OpenSBI provides a way to EDK2 for overriding SBI implementation ID (preferably using some API)

This is the PR according to the discussion we had in mail thread. However you may see some confusions from this

Ahh I see. This is very EDK2 specific. I was asking if this extension is required by other Bootloader/firmware. I guess the answer is no. I agree with John's proposal of an extension ID reserved per

Cool. This works for edk2. I will have another PR for this. For edk2, we will request a new SBI implementation ID (4) and register firmware code base extension SBI in edk2 SEC phase.

I agree with Jonathan's proposal. Let's have SBI FW extension ID depend on SBI implementation ID. We can target this for SBI v0.3 spec along with System Reboot extension. Regards, Anup Sent from

What I was suggesting is something like: > Implementation specific SBI extension Space, Extension IDs 0x0A000000 through 0x0AFFFFFF. Low bits from SBI Implementation ID. In this scheme, each SBI

Technologist) wrote: I prefer this one as well. But you should pick any value within experimental range. I am not sure about the purpose of the extension but if it has the potential to be a generic

Got it, Software ML removed. Johnathan, do you mean to define it as below? Firmware Base Extension, Extension ID: 0xxxxxxxxx (FWBE) , and the SBI functions definition is firmware code base

I think tech-unixplatformspec@... might be the right list? To address the PR itself, I'd personally prefer to have this space allocated based on SBI implementation IDs analogously to how the vendor

A general comment: it would be good to put the reason why a new extension is introduced, to solve what issue. Reviewed-by: Bin Meng <bmeng.cn@...>

This patch adds SBI v0.2 compliant system reboot extension. It defines the sbi_system_reboot function which does different things based on reboot_type parameter: 1. shutdown - Power-off the entire

Sure, I will fix this in next revision. Thanks for catching. Regards, Anup

> The System Reboot Extension provides a set of functions that allow the nit: "a set of functions" -> "a function"

This patch adds SBI v0.2 compliant system reboot extension. It defines the sbi_system_reboot function which does different things based on reboot_type parameter: 1. shutdown - Power-off the entire