|
Re: Proposal: SBI PMU Extension
That sounds good.
Greg
By
Greg Favor
·
#117
·
|
|
Re: Proposal: SBI PMU Extension
Hi Greg,
How about having event_idx as XLEN bits wide??
It can be encoded as follows (similar to what you suggested):
event_idx[XLEN-1:16] = info
event_idx[15:12] = type
event_idx[11:0] =
Hi Greg,
How about having event_idx as XLEN bits wide??
It can be encoded as follows (similar to what you suggested):
event_idx[XLEN-1:16] = info
event_idx[15:12] = type
event_idx[11:0] =
|
By
Anup Patel
·
#116
·
|
|
Re: Proposal: SBI PMU Extension
Essentially, Yes. This is a little different that what I had described, but this is equally fine (if not a little simpler). One can eliminate the separate event_info parameter and just have one
Essentially, Yes. This is a little different that what I had described, but this is equally fine (if not a little simpler). One can eliminate the separate event_info parameter and just have one
|
By
Greg Favor
·
#115
·
|
|
Re: Proposal: SBI PMU Extension
Yes, I think this should be 4-steps for HW counters.
The last step#3 will be broken down into programming hpmeventX CSR and optional platform specific progamming.
Regards,
Anup
Yes, I think this should be 4-steps for HW counters.
The last step#3 will be broken down into programming hpmeventX CSR and optional platform specific progamming.
Regards,
Anup
|
By
Anup Patel
·
#114
·
|
|
Re: Proposal: SBI PMU Extension
You are correct, 16bit CSR_number is sufficient.
I am thinking of using lower 12bit of CSR_number as absolute RISC-V CSR number. This way we can point to any (even implementation specific) CSR as
You are correct, 16bit CSR_number is sufficient.
I am thinking of using lower 12bit of CSR_number as absolute RISC-V CSR number. This way we can point to any (even implementation specific) CSR as
|
By
Anup Patel
·
#113
·
|
|
Re: Proposal: SBI PMU Extension
I agree HPMEVENT CSRs are sufficient for most RISC-V system assuming RV64 will be more common compared to RV32.
The M-mode runtime firmware (OpenSBI) will have to deal with implementation specific
I agree HPMEVENT CSRs are sufficient for most RISC-V system assuming RV64 will be more common compared to RV32.
The M-mode runtime firmware (OpenSBI) will have to deal with implementation specific
|
By
Anup Patel
·
#112
·
|
|
Re: Proposal: SBI PMU Extension
Hi Greg,
I support your suggestion for re-using hpmeventX CSRs for both selecting and filtering events but I am worried about RV32 because hpmeventX CSRs will be 32bit on RV32. Due to this reason,
Hi Greg,
I support your suggestion for re-using hpmeventX CSRs for both selecting and filtering events but I am worried about RV32 because hpmeventX CSRs will be 32bit on RV32. Due to this reason,
|
By
Anup Patel
·
#111
·
|
|
Re: Proposal: SBI PMU Extension
By
Anup Patel
·
#110
·
|
|
Re: Unix platform working group future agenda (to be discussed in next meeting (06/09 8AM PST))
It was a deal in the last decade. There was concern for support for boot devices like non-64-bit addressing capable USB, 32-bit BARs in PCI and possibly other such older protocols. Without requiring
It was a deal in the last decade. There was concern for support for boot devices like non-64-bit addressing capable USB, 32-bit BARs in PCI and possibly other such older protocols. Without requiring
|
By
Josh Scheid
·
#109
·
|
|
Re: Proposal: SBI PMU Extension
It seems to me that we should figure out the usage of event_idx. Who
is responsible to translate the event_idx to the real hw event of each
platform and how to translate it.
1. Monitor generic
It seems to me that we should figure out the usage of event_idx. Who
is responsible to translate the event_idx to the real hw event of each
platform and how to translate it.
1. Monitor generic
|
By
Zong Li
·
#108
·
|
|
Re: Proposal: SBI PMU Extension
In the following step #3, I think in most implementations the event selection would be a matter of writing the event_idx information into the hpmeventX CSR associated with hpmcounterX. The
In the following step #3, I think in most implementations the event selection would be a matter of writing the event_idx information into the hpmeventX CSR associated with hpmcounterX. The
|
By
Greg Favor
·
#107
·
|
|
Re: Proposal: SBI PMU Extension
Hi Greg,
I disagree. Are you proposing a way for software to overload some CSRs that were specifically named HPMEVENT? No matter what ...
Please check my comment at
Hi Greg,
I disagree. Are you proposing a way for software to overload some CSRs that were specifically named HPMEVENT? No matter what ...
Please check my comment at
|
By
alankao
·
#106
·
|
|
Re: Proposal: SBI PMU Extension
Why have CSR_number be a 32-bit value? Even a 16-bit value would be way, way more than enough. One could argue that even a byte - providing for up to 256 counters - is more than enough.
With a
Why have CSR_number be a 32-bit value? Even a 16-bit value would be way, way more than enough. One could argue that even a byte - providing for up to 256 counters - is more than enough.
With a
|
By
Greg Favor
·
#105
·
|
|
Re: Proposal: SBI PMU Extension
But that is the point of the standard HPMEVENT CSRs - each HPMCOUNTER CSR has an associated HPMEVENT CSR. With the expectation that the HPMEVENT CSR, in some manner, selects the event to be counted
But that is the point of the standard HPMEVENT CSRs - each HPMCOUNTER CSR has an associated HPMEVENT CSR. With the expectation that the HPMEVENT CSR, in some manner, selects the event to be counted
|
By
Greg Favor
·
#104
·
|
|
Re: Proposal: SBI PMU Extension
Anup,
Just to clarify a couple of things as to where I was coming from (which I think would mirror other people that also want to have more than just an event selector field in the hpmevent CSR's):
We
Anup,
Just to clarify a couple of things as to where I was coming from (which I think would mirror other people that also want to have more than just an event selector field in the hpmevent CSR's):
We
|
By
Greg Favor
·
#103
·
|
|
Re: Proposal: SBI PMU Extension
Sorry for unclear description in DT binding file. The event mapping of property
maps generic HW events of kernel to particular HW events of platform, doesn't
map to specific counters, so it doesn't
Sorry for unclear description in DT binding file. The event mapping of property
maps generic HW events of kernel to particular HW events of platform, doesn't
map to specific counters, so it doesn't
|
By
Zong Li
·
#102
·
|
|
Re: Proposal: SBI PMU Extension
Hi Greg,
Thanks for the feedbacks and requests.
I had kept event_idx to be just 15bits so that all possible events can be represented by a bitmap of 2048 bytes. I certainly see the advantage
Hi Greg,
Thanks for the feedbacks and requests.
I had kept event_idx to be just 15bits so that all possible events can be represented by a bitmap of 2048 bytes. I certainly see the advantage
|
By
Anup Patel
·
#101
·
|
|
Re: Proposal: SBI PMU Extension
By
Anup Patel
·
#100
·
|
|
Re: Proposal: SBI PMU Extension
Anup,
This is great to see - as part of standardizing how RISC-V HPM counters are configured and controlled by softare
I have a modest but important request: Increase the size of the event_idx 'code'
Anup,
This is great to see - as part of standardizing how RISC-V HPM counters are configured and controlled by softare
I have a modest but important request: Increase the size of the event_idx 'code'
|
By
Greg Favor
·
#99
·
|
|
Re: Proposal: SBI PMU Extension
Do we need the SBI calls to set the mcounteren and mcountinhibit (optional CSR)?
OR these two CSRs shouldn't be changed at runtime from s-moe?
I'm not sure whether I misunderstood the usage of
Do we need the SBI calls to set the mcounteren and mcountinhibit (optional CSR)?
OR these two CSRs shouldn't be changed at runtime from s-moe?
I'm not sure whether I misunderstood the usage of
|
By
Zong Li
·
#98
·
|