The hyperlink of the diagram can just contain the Figure index rather than entire title. The title of the figure should be center aligned. same as above. Thanks for the adding the diagrams. It looks g

Thanks for the patches. Merging this series via github PR it is already reviewed here.

I have updated the wiki page with today's notes. We did not get time to discuss this. I am planning to send a revised patch for EBBR. IMO, it can be used as is for UEFI boot flow in the platform speci

A book keeping improvement suggestion about Copyrights The specification still contains a copyright on Palmer & My name as there were no other contributors at that time. We have 13 contributors now an

nit: It should be EID #0x10 to make it more consistent with FIDs. Everything else looks good to me. Reviewed-by: Atish Patra <atish.patra@...>

Apart from the typo Philipp pointed out, everything else looks good to me. Reviewed-by: Atish Patra <atish.patra@...>

I think the current version should be in the title page but in a next line similar to platform spec. I think we should move this to a change log section to be in compatible with Platform spec. Should

I think SBI specification should follow the same formatting as the platform spec. Here are few differences in generated pdf. 1. First page should contain the title and a version in next line with smal

Reviewed-by: Atish Patra <atish.patra@...>

Reviewed-by: Atish Patra <atish.patra@...>

Does it need to be specified in SBI specification or platform specification ? Platform specification anyways should have a section about state of machine while entering M/S mode. Keeping the same info

I am fine with either way.

There is a brief valid hart definition in binary encoding section as well. "any of the hartid from hart_mask is not valid i.e. either the hartid is not enabled by the platform or is not available to t

Reviewed-by: Atish Patra <atish.patra@...>

The meeting is switched to Monday 9AM every week to avoid conflict. The calendar is updated as well. The next "Profiles and Platform Spec TS" meeting is scheduled on Mon, October 26, 9am – 10am. Sorry

Looks good to me. I don't see a reviewed-by tag as this is not actual patch. I have approved the PR in github. https://github.com/riscv/riscv-sbi-doc/pull/61 For future reference, it is preferred that

Current SBI interface provides these features that is outside scope of UEFI. 1. IPI, SFENCE, Hart State Management(CPU hotplug), Timer management In future, there will be RESET/SUSPEND (either direct

I am not sure how to represent this without ambiguity. There will be two kinds of firmware interfaces. UEFI/ACPI that will use SBI internally for some of the runtime services (Not All). S-mdoe OS will

For the entire series: Reviewed-by: Atish Patra <atish.patra@...>

That's awesome. I did not know that you have a working RTL implementation with H extension. Absolutely. I have added your talk to the agenda for upcoming meeting on 27th october. Yes. It would be very