This is my understanding as well. We should not force Linux to only call EFI runtime services to do the reboot. Regards, Bin

<mchitale@...> wrote: nits: 2 SoB here Is ACPI mandatory? at least Is this mechanism a standard one, or platform specific? at least typo: implement typo: access typo: visibility typo: sec

Mention that an SBI extension shall not be partially implemented. Signed-off-by: Bin Meng <bmeng.cn@...> --- Changes in v2: - %s/a SBI/an SBI - reword the clarification riscv-sbi.adoc | 6 ++++++

Hi Atish, Okay, I will send v2. Regards, Bin

%s/a SBI/an SBI/ %s/A SBI/An SBI/ Signed-off-by: Bin Meng <bmeng.cn@...> --- riscv-sbi.adoc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/riscv-sbi.adoc b/riscv-

Hi Heinrich, Sure. Will send a new patch to fix other places in the same file. How about: If sbi_probe_extension() signals that an extension is available, all functions that conform to the SBI version

Signed-off-by: Bin Meng <bmeng.cn@...> --- riscv-sbi.adoc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/riscv-sbi.adoc b/riscv-sbi.adoc index 11c30c3..8696f97 100644 --- a/riscv-sbi.ad

I can send a patch. I know probe() can be helpful. I just don't see the value of using version number to determine whether a certain SBI extension is avaiable. Regards, Bin

If CPU is successfully suspended, then the function is implemented by SBI firmware. I don't see why I need to care about the version number. If suspend function is not available, then SBI_ERR_NOT_SUPP

Any function not supported, OS can make the SBI call, and check its return value against SBI_ERR_NOT_SUPPORTED. I don't believe an arbitrary version number really helps here. Like you said, SRST exten

Do we have policies, or planning/schedule of versions? What is the version supposed to be used for? Regards, Bin

Reviewed-by: Bin Meng <bmeng.cn@...>

What's our policy of bumping up versions? Is there no version 0.3, but just -rc0? I am not sure DSYN is a good name. How about DMAS? Does RVI have plan to introduce cache instructions into the ISA? Th

Reviewed-by: Bin Meng <bmeng.cn@...>

<alistair.francis@...> wrote: Reviewed-by: Bin Meng <bmeng.cn@...>

<alistair.francis@...> wrote: Yes, this patch should be re-generated via "git format-patch -M" which can detect file rename. Regards, Bin

Hi Anup, If we go for solution 2, S-mode software is still able to issue reset the whole system directly using CONFIG_SYSRESET sort of drivers. Is this an expected use case? Regards, Bin

<daniel.schaefer@...> wrote: Reviewed-by: Bin Meng <bin.meng@...>

A general comment: it would be good to put the reason why a new extension is introduced, to solve what issue. Reviewed-by: Bin Meng <bmeng.cn@...>

One generic comment, pretty much similar to the SBI PMP extension I proposed, is that why is this necessary to introduce a new SBI extension to support reboot and shutdown? Do these functionalities ha