On 06/08/21, 1:21 PM, "Heinrich Schuchardt" <heinrich.schuchardt@...> wrote:
On 8/6/21 8:19 AM, Anup Patel wrote:
> We don't need a table for required SBI extensions and UEFI interfaces
> is implemented by UEFI firmware.
%s/is//
[Anup] Okay, will update.
>
> Signed-off-by: Anup Patel <anup.patel@...>
> ---
> riscv-platform-spec.adoc | 47 ++++++++++++++++++----------------------
> 1 file changed, 21 insertions(+), 26 deletions(-)
>
> diff --git a/riscv-platform-spec.adoc b/riscv-platform-spec.adoc
> index 3994ef3..675ace0 100644
> --- a/riscv-platform-spec.adoc
> +++ b/riscv-platform-spec.adoc
> @@ -448,34 +448,31 @@ mentioned in the requirements.
>
>
> ==== Runtime Services
> -===== SBI
> -
> -- Required SBI spec version is 0.3 or higher.
> -- Required SBI extensions -
>
> -[cols="1,2", width=80%, align="left", options="header"]
> -|===
> -|EXTENSION | CONDITIONS
> -|SBI TIME | if **stimecmp** CSR not available
> -|SBI IPI |
> -|SBI RFENCE |
> -|SBI HSM |
> -|SBI SRST |
> -|SBI PMU |
> -|===
> -
> -- Required responsibilities of M-Mode runtime also includes -
> - ** Interrupt and Exception Delegation
> - ** Misaligned Load & Stores handling
> - ** Missing CSRs emulation
> - ** PMP Configuration
> +===== SBI
>
> -- Wherever applicable firmware must implement UEFI interfaces over similar
> -interfaces and services present in the SBI specification. For example, UEFI
> -runtime services must implement ResetSystem() via SBI Reset extension.
> +* The M-mode runtime must implement SBI specification version 0.3
> + or higher
> +* Required SBI extensions include:
> +** SBI TIME
> +** SBI IPI
> +** SBI RFENCE
> +** SBI HSM
> +** SBI SRST
> +** SBI PMU
> +* Required features of the M-Mode runtime also includes
> +** Delegate interrupts and exceptions to S-mode
> +** Handle misaligned load and store
> +** Emulate missing CSRs
> +** Configure PMP CSRs
>
> ===== UEFI
> -- OS should prioritize calling the UEFI interfaces before the SBI or Platform
> +
> +* Wherever applicable UEFI firmware must implement UEFI interfaces over
> + similar interfaces and services present in the SBI specification. For
> + example, the UEFI ResetSystem() service must be implemented via the
> + SBI System Reset Extension.
> +* OS should prioritize calling the UEFI interfaces before the SBI or Platform
An article is missing. I prefer the complete term over the abbreviation:
%s/OS/The operating system/
%s/Platform specific/platform specific/
[Anup] Okay, will update.
Regards,
Anup
Best regards
Heinrich
> specific mechanisms.
>
> // Server extension for OS-A Platform
> @@ -675,8 +672,6 @@ process.
> |===
>
> ===== Runtime services
> -====== SBI
> -*TBD*
>
> ====== UEFI
> The UEFI run time services listed below are required to be implemented.
>
