Please see inline below...
Regards,
Anup
On 29/07/21, 12:21 AM, "Heinrich Schuchardt" <xypron.glpk@...> wrote:
On 28.07.21 15:33, Anup Patel wrote:
> We don't need a table for required SBI extensions and UEFI interfaces
> is implemented by UEFI firmware.
>
> Signed-off-by: Anup Patel <anup.patel@...>
> ---
> riscv-platform-spec.adoc | 33 ++++++++++++++-------------------
> 1 file changed, 14 insertions(+), 19 deletions(-)
>
> diff --git a/riscv-platform-spec.adoc b/riscv-platform-spec.adoc
> index 7261704..29fa821 100644
> --- a/riscv-platform-spec.adoc
> +++ b/riscv-platform-spec.adoc
> @@ -453,31 +453,26 @@ mentioned in the requirements.
>
>
> ==== Runtime Services
> -===== SBI
> -
> -- Required SBI spec version is 0.3 or higher.
> -- Required SBI extensions -
>
> -[cols="1,2", width=80%, align="left", options="header"]
> -|===
> -|EXTENSION | CONDITIONS
> -|SBI TIME | if **stimecmp** CSR not available
> -|SBI IPI |
> -|SBI RFENCE |
> -|SBI HSM |
> -|SBI SRST |
> -|SBI PMU |
> -|===
> +===== SBI
>
> -- Required responsibilities of M-Mode runtime also includes -
> +* Required SBI spec version is 0.3 or higher
Content-wise I am happy. I would just change the wording and a bit:
The M-mode runtime must implement SBI specification version 0.3 or higher.
[Anup] Sure, I will use the suggested sentence.
> +* Required SBI extensions includes:
%s/includes/include/
[Anup] Okay, will update.
> + ** SBI TIME
> + ** SBI IPI
> + ** SBI RFENCE
> + ** SBI HSM
> + ** SBI SRST
> + ** SBI PMU
> +* Required responsibilities of M-Mode runtime also includes
%s/responsibilities/features/ ?
[Anup] Yes, "features" sounds much better here.
%s/of M-Mode/of the M-mode/
[Anup] Okay, will update.
> ** Interrupt and Exception Delegation
> ** Misaligned Load & Stores handling
Either both singular or both plural.
[Anup] Okay, will update.
> ** Missing CSRs emulation
> ** PMP Configuration
Only proper names should be capitalized.
[Anup] Okay, will update.
> -
> -- Wherever applicable firmware must implement UEFI interfaces over similar
> -interfaces and services present in the SBI specification. For example, UEFI
> -runtime services must implement ResetSystem() via SBI Reset extension.
> +* Wherever applicable UEFI firmware must implement UEFI interfaces over
> + similar interfaces and services present in the SBI specification. For
> + example, UEFI runtime services must implement ResetSystem() via SBI
> + Reset extension.
For example the UEFI ResetSystem() runtime service must be implemented
via the SBI System Reset Extension.
[Anup] Okay, will update.
Best regards
Heinrich
>
> ===== UEFI
> - OS should prioritize calling the UEFI interfaces before the SBI or Platform
>
